Skip to content

chore: upgrade go-ethereum to fix MorphTx version JSON unmarshaling#894

Merged
panos-xyz merged 1 commit intotest_3_13from
fix/morph-tx-version-json
Mar 3, 2026
Merged

chore: upgrade go-ethereum to fix MorphTx version JSON unmarshaling#894
panos-xyz merged 1 commit intotest_3_13from
fix/morph-tx-version-json

Conversation

@panos-xyz
Copy link

Summary

  • Upgrade github.com/morph-l2/go-ethereum from v1.10.14-0.20260227074910-324c53b65341 to v1.10.14-0.20260302105006-9e26fa129767
  • Fixes syncing nodes failing with json: cannot unmarshal string into Go struct field rpcBlock.transactions.version of type uint8

Background

After MorphTx V1 was introduced, the version field in RPCTransaction (api.go) was serialized as a hex string ("0x1" via hexutil.Uint64), but the client-side txJSON.Version was *uint8 expecting a plain number. This caused ethclient.BlockByNumber to fail on all non-sequencer nodes when syncing blocks that contain MorphTx V1 transactions.

The fix in go-ethereum aligns txJSON.Version with the Ethereum JSON-RPC hex encoding convention.

Changes

  • Updated go.mod + go.sum in: node, tx-submitter, oracle, contracts, bindings, ops/tools, ops/l2-genesis, token-price-oracle

Test plan

  • Verify non-sequencer node can sync blocks containing MorphTx V1 transactions without BlockByNumber errors

@panos-xyz panos-xyz requested a review from a team as a code owner March 2, 2026 10:59
@panos-xyz panos-xyz requested review from secmgt and removed request for a team March 2, 2026 10:59
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/morph-tx-version-json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@panos-xyz panos-xyz force-pushed the fix/morph-tx-version-json branch from e8dafcc to 6474b6e Compare March 2, 2026 11:27
Upgrade github.com/morph-l2/go-ethereum from
v1.10.14-0.20260227074910-324c53b65341 to
v1.10.14-0.20260302105006-9e26fa129767

The new version fixes "cannot unmarshal string into Go struct field
rpcBlock.transactions.version of type uint8" error that occurred when
non-sequencer nodes called BlockByNumber to sync blocks containing
MorphTx V1 transactions.
@panos-xyz panos-xyz force-pushed the fix/morph-tx-version-json branch from 6474b6e to 123d3eb Compare March 2, 2026 11:31
@panos-xyz panos-xyz merged commit 4d6329b into test_3_13 Mar 3, 2026
9 checks passed
@panos-xyz panos-xyz deleted the fix/morph-tx-version-json branch March 3, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant