Skip to content

Conversation

@josiahbergen
Copy link

@josiahbergen josiahbergen commented Jan 21, 2026

Description

the query that gets the keytips element in updateKeytips() was broken (probably outdated?). this change simply fixes the selector, restoring proper functionality.

also changes the text of the updated text, reflecting the current default in the html!

Checks

  • Adding/modifying Typescript code?
    • I have used qs, qsa or qsr instead of JQuery selectors.
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Copilot AI review requested due to automatic review settings January 21, 2026 20:08
@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jan 21, 2026
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 21, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where footer keytips were not updating to reflect the current configuration. The issue was caused by an outdated CSS selector that failed to target the keytips element.

Changes:

  • Updated the CSS selector from class-based (.keyTips) to ID-based (#keyTips) to match the actual DOM structure
  • Added the missing id="keyTips" attribute to the Footer component
  • Changed "+" to "and" in the keytip text for consistency

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
monkeytype Subproject commit reference update
frontend/src/ts/ui.ts Fixed CSS selector and updated keytip text formatting
frontend/src/ts/components/layout/footer/Footer.tsx Added missing id attribute to enable proper element selection

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Miodec Miodec closed this in 2f0a523 Jan 21, 2026
@Miodec
Copy link
Member

Miodec commented Jan 21, 2026

Thanks for your PR! However, with #7382 getting merged, the actual solution is a bit simpler and cleaner - ill implement it quickly myself. Thanks for pointing out this mistake though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff waiting for review Pull requests that require a review before continuing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants