Fix changelog diff for dependency specifier updates#13644
Closed
tsbinns wants to merge 63 commits intomne-tools:mainfrom
Closed
Fix changelog diff for dependency specifier updates#13644tsbinns wants to merge 63 commits intomne-tools:mainfrom
tsbinns wants to merge 63 commits intomne-tools:mainfrom
Conversation
Co-authored-by: Carina Forster <carinaforster0611@gmail.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Contributor
Author
|
Sorry, screwed up the diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Discussed in #13641
What does this implement/fix?
@larsoner, turns out when the specifiers/markers are being prettified,
'inpyproject.tomlbecomes"(e.g.,'Darwin'->"Darwin"). Was enough for the check for changed requirements to be triggered.Just added the conversion of any double back to single quotation marks.