Flake8, fix minor bug, and work properly when AFS isn't enabled in kernel#4
Open
jikamens wants to merge 3 commits intomit-athena:masterfrom
Open
Flake8, fix minor bug, and work properly when AFS isn't enabled in kernel#4jikamens wants to merge 3 commits intomit-athena:masterfrom
jikamens wants to merge 3 commits intomit-athena:masterfrom
Conversation
added 3 commits
May 24, 2017 09:41
If we get ENOSYS when attempting to treat something as an AFS path, then that means AFS isn't enabled in the kernel, so obviously it's not an AFS path and that's how we should treat it. Fixes https://debathena.mit.edu/trac/ticket/1584.
Member
|
From reading through this, changes look fine. I haven't tried to run it or re-lint it. Is there anything blocking merging this? (I think I have bits to do it, but it's been a long time since I've done anything.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.