don't focus list item when suggest setting is never
#282503
Merged
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the first suggestion item was briefly focused even when the selection mode setting is set to never. This caused downstream listeners to incorrectly treat the first item as chosen.
Key Changes
- Move
selectionModeandnoFocuscomputation to the beginning ofshowSuggestions()method - Remove redundant
setFocus([selectionIndex])call that was causing the brief focus - Keep single conditional
setFocus()call that respects thenoFocusflag
Tyriar
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #282461
Previously the code always focused
selectionIndexonce and only then cleared it for the never case, so the first item briefly became focused/selected. With the change, the list is populated without ever focusing an item when never is set, so nothing is preselected.never.mov