Remove any cast #282496
Closed
Remove any cast #282496
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #269213
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a TypeScript any cast from terminal process code, part of a larger effort tracked in issue #269213 to eliminate unsafe type casts throughout the codebase. The change indicates that node-pty now natively supports Buffer types in its write method, making the workaround cast unnecessary.
- Removes
as anycast from Buffer.from() call when writing binary data to node-pty - Removes outdated TODO comment referencing pending node-pty PR #812
- Removes eslint-disable directive for the no-any-casts rule
Member
Author
|
Need to revert the node-pty change due to product build failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #269213