Skip to content

Conversation

@mrleemurray
Copy link
Contributor

@mrleemurray mrleemurray commented Dec 10, 2025

Introduce a new border color for unfocused agent session badges and update the corresponding CSS styling to reflect this change. This enhancement improves visual distinction for selected agent sessions when the view is not focused.

Recording 2025-12-10 at 11 05 33

@mrleemurray mrleemurray requested review from bpasero and Copilot and removed request for Copilot December 10, 2025 11:12
@mrleemurray mrleemurray self-assigned this Dec 10, 2025
@mrleemurray mrleemurray marked this pull request as ready for review December 10, 2025 11:12
Copilot AI review requested due to automatic review settings December 10, 2025 11:12
@mrleemurray mrleemurray added this to the December / January 2026 milestone Dec 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces visual distinction for selected agent session badges when the agent sessions view is unfocused. It adds a new theme color agentSessionSelectedUnfocusedBadge.border that provides a more subtle border color (using transparent foreground) compared to the focused state (which uses transparent listActiveSelectionForeground).

Key Changes

  • New theme color registration for unfocused badge borders with appropriate light/dark/high contrast variants
  • CSS rule using .monaco-list:not(:focus) selector to override the focused badge border when the list loses focus
  • Stylelint configuration updated to include the new CSS variable

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessions.ts Adds agentSessionSelectedUnfocusedBadgeBorder color registration with appropriate theming values for all color modes
src/vs/workbench/contrib/chat/browser/agentSessions/media/agentsessionsviewer.css Adds CSS rule to apply the unfocused badge border color when the monaco-list is not focused
build/lib/stylelint/vscode-known-variables.json Registers the new CSS variable for stylelint validation (with one unintended deletion of an existing variable)

@mrleemurray mrleemurray merged commit 63f0feb into main Dec 10, 2025
28 checks passed
@mrleemurray mrleemurray deleted the mrleemurray/striped-ocelot-ivory branch December 10, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants