Prevent extension host restart when notebook cells are executing #282386
+205
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a folder to workspace triggers an extension host restart that silently kills running Jupyter cells, losing hours of computation for long-running operations like dataset downloads or model training.
Changes
Veto mechanism for active notebook executions:
hasRunningExecutions()toINotebookExecutionStateServicethat checks for cells inPendingorExecutingstatesNotebookExecutionRestartVetoworkbench contribution that vetoesextensionService.onWillStopevents when cells are runningState tracking:
Unconfirmedexecutions (not yet started)Implementation follows the debug service veto pattern (see
debugService.ts:208-213).Testing
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.