Add meaningful error messages when calling notebook APIs before list view initialization #282378
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notebook editor contributions are instantiated before the
_list(NotebookCellList) is created, causing cryptic "Cannot read property of undefined" errors when calling viewzone or overlay APIs in contribution constructors.Changes
Added guard checks to three methods in
NotebookEditorWidget:changeViewZones()- Throws clear error if_listis not initializedgetViewZoneLayoutInfo()- Throws clear error if_listis not initializedchangeCellOverlays()- Throws clear error if_listis not initializedError messages now explain the problem and suggest deferring calls until after the notebook editor is fully initialized (e.g., after view model attachment).
Example
Before: Calling from a contribution constructor resulted in:
After: Clear, actionable error:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.