Skip to content

Conversation

Copy link

Copilot AI commented Dec 9, 2025

Invalid interpreter errors now appear as modal dialogs instead of dismissible notifications, increasing visibility for blocking errors when running files, starting REPL, or debugging.

Changes

  • Modified DiagnosticCommandPromptHandlerService.displayMessage() to pass { modal: true } for all error-severity diagnostics
  • Updated unit tests to verify modal option is correctly applied to error messages while warnings/info remain non-modal

Implementation

// Before
return this.appShell.showErrorMessage(message, ...prompts);

// After
return this.appShell.showErrorMessage(message, { modal: true }, ...prompts);

This applies to all error-level diagnostics including InvalidPythonInterpreterDiagnostic and NoPythonInterpretersDiagnostic, ensuring users must acknowledge blocking errors before continuing.

Original prompt

This section details on the original issue you should resolve

<issue_title>Change "invalid interpreter" notification to a modal dialog </issue_title>
<issue_description>
Right now when there's an invalid interpreter selected for the workspace and you try to run a file or start the REPL, for example, we display an error notification. Feedback from the broader team was that we should probably change it to a modal dialog since it's an "blocking" error, to drive higher discoverability of the failure point. </issue_description>

Comments on the Issue (you are @copilot in this section)

@luabud I think this is an example of a modal dialog in the Jupyter extension: https://github.com/microsoft/vscode-jupyter/blob/main/src/notebooks/controllers/commands/installPythonControllerCommands.ts#L52

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Modified DiagnosticCommandPromptHandlerService to display error severity diagnostics as modal dialogs
- Updated all related unit tests to expect modal option for error messages
- This makes invalid interpreter errors more prominent and blocking as requested

Co-authored-by: eleanorjboyd <[email protected]>
Copilot AI changed the title [WIP] Change invalid interpreter notification to modal dialog Display invalid interpreter errors as modal dialogs Dec 9, 2025
Copilot AI requested a review from eleanorjboyd December 9, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change "invalid interpreter" notification to a modal dialog

2 participants