Fix remote selection when upstream points to non-GitHub remote #8274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a branch's upstream is set to a non-GitHub remote (e.g.,
originpointing to an internal git server),getOrigin()throwsBadUpstreamErroreven when valid GitHub remotes are configured viagithubPullRequests.remotes. This breaks "Start Working on Issue" functionality.Changes
folderRepositoryManager.ts: ModifiedgetOrigin()to fall back to configured GitHub remotes when upstream is not GitHub, using the same selection logic as when no upstream is set (by convention, by ownership, or first available)folderRepositoryManager.test.ts: Added test case verifying fallback behavior when branch upstream points to non-GitHub remoteExample scenario
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.