Skip to content

Conversation

@tnaum-ms
Copy link
Collaborator

@tnaum-ms tnaum-ms commented Jun 16, 2025

Copilot AI and others added 30 commits May 26, 2025 15:25
…-documentdb into dev/xingfan/111-copy-and-paste-2-implement-basic-copy-and-paste-task
…into dev/xingfan/111-copy-and-paste-2-implement-basic-copy-and-paste-task
@tnaum-ms
Copy link
Collaborator Author

@copilot This branch is out-of-date with the base branch. Merge the latest changes from next into this branch. Resolve conflicts:
bundle.l10n.json can be ignored/replaced with any version - simply run 'npm run l10n' to generate a new one.
for docs/learn-more/index.md, use the version from 'next'

Copy link
Contributor

Copilot AI commented Nov 27, 2025

@tnaum-ms I've opened a new pull request, #409, to work on those changes. Once the pull request is ready, I'll request review from you.

@tnaum-ms tnaum-ms force-pushed the feature/copy-and-paste branch from d1706ce to b9346e3 Compare November 27, 2025 15:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 52 out of 54 changed files in this pull request and generated 1 comment.

Comment on lines +70 to +75
if (targetNode) {
context.telemetry.properties.targetNodeProperties = Object.getOwnPropertyNames(targetNode).join(',');
context.telemetry.properties.targetNodeHasCluster = String('cluster' in targetNode);
context.telemetry.properties.targetNodeHasDatabaseInfo = String('databaseInfo' in targetNode);
context.telemetry.properties.targetNodeHasCollectionInfo = String('collectionInfo' in targetNode);
}
Copy link

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This use of variable 'targetNode' always evaluates to true.

Suggested change
if (targetNode) {
context.telemetry.properties.targetNodeProperties = Object.getOwnPropertyNames(targetNode).join(',');
context.telemetry.properties.targetNodeHasCluster = String('cluster' in targetNode);
context.telemetry.properties.targetNodeHasDatabaseInfo = String('databaseInfo' in targetNode);
context.telemetry.properties.targetNodeHasCollectionInfo = String('collectionInfo' in targetNode);
}
context.telemetry.properties.targetNodeProperties = Object.getOwnPropertyNames(targetNode).join(',');
context.telemetry.properties.targetNodeHasCluster = String('cluster' in targetNode);
context.telemetry.properties.targetNodeHasDatabaseInfo = String('databaseInfo' in targetNode);
context.telemetry.properties.targetNodeHasCollectionInfo = String('collectionInfo' in targetNode);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Easy Lightweight Data Migrations 🚀

3 participants