Skip to content

Conversation

@bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Dec 10, 2025

Plus a few other things I did:

  • Loads of lint fixes
  • Put *.map into the .npmignores, so that source maps aren't in the tgz. They were interfering with debugging.
  • Fixed some issues in RegistryV2DataProvider.ts including some mostly-transparent bugs
  • Added UTs for conditional which is a very confusing method
  • Added a prelint script to build vscode-processutils, else linting does not work for the packages that depend on it

@bwateratmsft bwateratmsft requested a review from a team as a code owner December 10, 2025 16:24
@bwateratmsft bwateratmsft added the engineering Related to engineering label Dec 10, 2025
@bwateratmsft bwateratmsft requested a review from Copilot December 10, 2025 16:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates three packages (vscode-processutils, vscode-inproc-mcp, vscode-docker-registries, and vscode-container-client) to use a new centralized engineering package (@microsoft/vscode-azext-eng) for ESLint configuration and tooling. The migration includes updating to ESLint v9's flat config format, improving type safety, and modernizing code patterns.

Key Changes:

  • Migration from legacy .eslintrc.json to modern eslint.config.mjs (ESLint flat config)
  • Consolidation of dev dependencies into the new @microsoft/vscode-azext-eng package
  • Type safety improvements: anyunknown, ||??, improved type guards
  • Removal of redundant async keywords and Promise wrapping

Reviewed changes

Copilot reviewed 67 out of 68 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Replaced individual ESLint/testing dependencies with @microsoft/[email protected]
packages/*/eslint.config.mjs Added new flat ESLint configurations using shared presets
packages/*/.eslintrc.json Removed legacy ESLint configurations
packages/*/.eslintignore Removed legacy ignore files (handled by flat config)
packages/*/.npmignore Added exclusions for new config files and source maps
Type guard functions Improved from any to unknown with proper type narrowing
Nullish coalescing Changed `
Async methods Removed unnecessary async keywords where methods just return Promises
Test files Removed unused error parameters and improved type assertions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bwateratmsft bwateratmsft enabled auto-merge (squash) December 10, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engineering Related to engineering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants