feat: Add a redactor that uses RapidHash #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeknoid
force-pushed
the
redactors
branch
2 times, most recently
from
3631781 to
0372c2e
Compare
ralfbiedert
approved these changes
Dec 9, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=========================================
Coverage 100.0% 100.0%
=========================================
Files 33 68 +35
Lines 3291 6921 +3630
=========================================
+ Hits 3291 6921 +3630 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geeknoid
force-pushed
the
redactors
branch
3 times, most recently
from
cbae4cf to
01a6e42
Compare
Vaiz
reviewed
Dec 10, 2025
Vaiz
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since RapidHash is faster than xxH3, we should support it.
Also, remove some non-sensical trait implementations for the xxH3Redactor and the SimpleRedactor.
Redactors should not be Ord, PartialOrd, or Hash.