Allow GraphBuilder to call script functions by gramalingam · Pull Request #2820 · microsoft/onnxscript

gramalingam · 2026-02-20T22:27:06Z

This extension allows calls to scripted functions within traced (GraphBuilder) calls.
As part of this extension, allow the use of OpBuilder within scripted function
Also fix the default value naming strategy to include node number to ensure uniqueness (in common cases).

TODO later: Consider integration of standard execution of script functions with execution of OpBuilder calls, as well as other extensions within script-mode to ensure both modes are seamless and uniform

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

onnxscript/_internal/builder_test.py

github-advanced-security

lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

codecov · 2026-02-20T23:38:10Z

Codecov Report

❌ Patch coverage is 79.51807% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.80%. Comparing base (7c7f760) to head (85418f9).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
onnxscript/_internal/builder_test.py	82.29%	17 Missing ⚠️
onnxscript/_internal/_inliner.py	63.15%	5 Missing and 2 partials ⚠️
onnxscript/_internal/builder.py	87.50%	2 Missing and 3 partials ⚠️
onnxscript/_internal/converter.py	54.54%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2820      +/-   ##
==========================================
+ Coverage   70.76%   70.80%   +0.04%     
==========================================
  Files         231      232       +1     
  Lines       27667    27818     +151     
  Branches     2775     2798      +23     
==========================================
+ Hits        19579    19697     +118     
- Misses       7127     7154      +27     
- Partials      961      967       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

onnxscript/_internal/builder.py

Copilot

Pull request overview

This pull request enables GraphBuilder/OpBuilder to call @script-decorated ONNXScript functions, allowing seamless composition of imperative (builder) and declarative (script) code. The PR also updates the default output naming strategy to include node numbers for better uniqueness.

Changes:

Added call() method to GraphBuilder and OpBuilder that inlines script functions into the builder's graph
Modified converter to accept OpBuilder as a default_opset parameter, converting it to Opset internally
Updated default output naming from {op_type}_output to {op_type}_n{count}_output for uniqueness
Created new _inliner.py module with function instantiation logic

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
onnxscript/_internal/builder.py	Added `call()` methods and domain/version properties to OpBuilder; updated naming strategy
onnxscript/_internal/converter.py	Added support for OpBuilder as default_opset with automatic conversion to Opset
onnxscript/_internal/_inliner.py	New module providing function instantiation/inlining capabilities
onnxscript/_internal/builder_test.py	Comprehensive tests for call() functionality with various options (_outputs, _prefix)
docs/tutorial/builder/graph_builder.md	Documentation for calling script functions from OpBuilder

onnxscript/_internal/builder_test.py

onnxscript/_internal/_inliner.py

onnxscript/_internal/builder.py

onnxscript/_internal/converter.py

onnxscript/_internal/builder_test.py

onnxscript/_internal/builder.py

onnxscript/_internal/builder_test.py

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

onnxscript/_internal/builder.py

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

onnxscript/_internal/_inliner.py

@@ -0,0 +1,58 @@
+# Copyright (c) Microsoft Corporation.


onnxscript/_internal/_inliner.py

@@ -0,0 +1,58 @@
+# Copyright (c) Microsoft Corporation.


onnxscript/_internal/_inliner.py

+    nodes = [cloner.clone_node(n) for n in function]
+    outputs = [value_map.get(v) for v in function.outputs]
+    return nodes, outputs
+


onnxscript/_internal/_inliner.py

+            f"Too many inputs: got {len(inputs)}, "
+            f"but function has {len(formal_inputs)} parameters."
+        )
+    value_map: dict[ir.Value, ir.Value | None] = {


onnxscript/_internal/_inliner.py

+            f"Too many inputs: got {len(inputs)}, "
+            f"but function has {len(formal_inputs)} parameters."
+        )
+    value_map: dict[ir.Value, ir.Value | None] = {


justinchuby · 2026-02-21T05:30:58Z

onnxscript/_internal/builder.py

            else:
                names = [
-                    f"{op_type}_output{i}" if op_type else f"output{i}" for i in range(outputs)
+                    f"{op_type}_n{count}_output{i}" if op_type else f"n{count}_output{i}" for i in range(outputs)


There may be some conflicts: I updated the naming patterns in #2819

gramalingam added 6 commits February 19, 2026 16:59

Add call function

50ca21b

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

Add test case

255e747

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

Cleanup

ffddfd7

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

Add naming options to function call

2786955

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

Support OpBuilder in converter

5236801

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

Update documentation

f66a197

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

github-project-automation bot added this to ONNX Script Review Board Feb 20, 2026

github-project-automation bot moved this to Todo in ONNX Script Review Board Feb 20, 2026

github-advanced-security bot found potential problems Feb 20, 2026

View reviewed changes

onnxscript/_internal/builder_test.py Fixed Show fixed Hide fixed

onnxscript/_internal/builder_test.py Fixed Show fixed Hide fixed

github-code-quality bot found potential problems Feb 20, 2026

View reviewed changes

onnxscript/_internal/builder_test.py Fixed Show fixed Hide fixed

onnxscript/_internal/builder_test.py Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Feb 20, 2026

View reviewed changes

justinchuby requested a review from Copilot February 21, 2026 00:23

Copilot started reviewing on behalf of justinchuby February 21, 2026 00:23 View session

justinchuby reviewed Feb 21, 2026

View reviewed changes

onnxscript/_internal/builder.py Outdated Show resolved Hide resolved

Copilot AI reviewed Feb 21, 2026

View reviewed changes

gramalingam and others added 5 commits February 20, 2026 16:58

Potential fix for code scanning alert no. 22056: Unused import

f053357

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Potential fix for code scanning alert no. 22055: Unused local variable

8d8b2ea

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Update onnxscript/_internal/builder.py

c6692fa

Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>

Update onnxscript/_internal/_inliner.py

241ba42

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update onnxscript/_internal/builder.py

d6d92f1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-code-quality bot found potential problems Feb 21, 2026

View reviewed changes

onnxscript/_internal/builder.py Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Feb 21, 2026

View reviewed changes

onnxscript/_internal/builder.py Fixed Show fixed Hide fixed

gramalingam added 3 commits February 20, 2026 17:15

Address review feedback

d2958f3

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

Address PR feedback

a35b8dd

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

Fix import

85418f9

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>

gramalingam enabled auto-merge (squash) February 21, 2026 01:20

github-advanced-security bot found potential problems Feb 21, 2026

View reviewed changes

justinchuby reviewed Feb 21, 2026

View reviewed changes

Comments

Conversation

gramalingam commented Feb 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-advanced-security bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Check warning

Check warning

Check notice

Check notice

justinchuby Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Feb 20, 2026 •

edited

Loading