Remove invalid asserts from WslMirroredNetworking.cpp#14151
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes two invalid assertions from WslMirroredNetworking.cpp that were checking for State::Started in callback functions. These assertions were invalid because callbacks can fire during shutdown after the state has been set to State::Stopped but before the callbacks are unregistered, creating a race condition. The code already handles this correctly by checking for State::Stopped immediately after the assertions and returning early.
Changes:
- Removed invalid
WI_ASSERT(manager->m_state == State::Started)fromHcnServiceConnectionTimerCallback - Removed invalid
WI_ASSERT(manager->m_state == State::Started)fromHcnCallback
keith-horton
approved these changes
Feb 3, 2026
benhillis
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change removes two invalid asserts from
src/windows/service/exe/WslMirroredNetworking.cppPR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed