AGR: Detect epsilon-reachable cycles in grammar compiler#1955
Merged
curtisman merged 1 commit intomicrosoft:mainfrom Feb 28, 2026
Merged
AGR: Detect epsilon-reachable cycles in grammar compiler#1955curtisman merged 1 commit intomicrosoft:mainfrom
curtisman merged 1 commit intomicrosoft:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grammarCompiler.ts: addscompilingandnullablefields toDefinitionRecordto track in-progress rule compilation and whether a rule alternative can match the empty string (ε). During compilation, the set of rule names entered since the last mandatory token was consumed (epsilonReachable) is threaded throughcreateNamedGrammarRules/createGrammarRules/createGrammarRule. A compile-time error is raised when a rule reference is encountered whose name is already in that set, meaning the grammar would loop infinitely at match time.grammarCompileError.spec.ts): 13 error cases (direct self-reference, mutual cycles, optional parts before back-references, Kleene-star groups, multiple independent cycles, etc.) and 10 valid-grammar cases confirming that non-epsilon recursion (mandatory literal before back-reference, Kleene-plus, number/wildcard variables, etc.) is accepted without error.grammarMatcher.spec.ts): 2 new tests verifying that right-recursive rules (which are valid) correctly match multi-token input at runtime.grammarStore.spec.ts): minor updates to align with the revised compiler behaviour.🤖 Generated with Claude Code