fix: add const qualifier to y_col pointer (Clang 20 compatibility)#484
Closed
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix: add const qualifier to y_col pointer (Clang 20 compatibility)#484Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Line 811 initializes y_col as int8_t* but it's only read from (used as const in py pointer below). Clang 20 is stricter about const-correctness and throws error: 'cannot initialize a variable of type int8_t* with an rvalue of type const int8_t*' This fix aligns with line 906 which already uses const int8_t*.
Author
|
didn't notice about that, sry about this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Line 811 in
src/ggml-bitnet-mad.cppinitializesy_colasint8_t*but it is only read from (used asconstin thepypointer below).Problem
Clang 20 is stricter about const-correctness and throws error:
Fix
Changed line 811 from:
int8_t * y_col = y + col * by;to:
This fix aligns with line 906 which already uses
const int8_t*.Testing
This fix resolves the Clang 20 build error on Ubuntu 24.04.