Rebased: Feature/promise based request interceptors#1433
Open
lukeggchapman wants to merge 2 commits intomgonto:masterfrom
lukeggchapman:feature/promise-based-request-interceptors
Open
Rebased: Feature/promise based request interceptors#1433lukeggchapman wants to merge 2 commits intomgonto:masterfrom lukeggchapman:feature/promise-based-request-interceptors
lukeggchapman wants to merge 2 commits intomgonto:masterfrom
lukeggchapman:feature/promise-based-request-interceptors
Conversation
added 2 commits
October 26, 2016 01:35
|
This is already a few months old. Will it me merged? |
Collaborator
|
I'd have to have a proper look at the code, haven't had time yet though. If @lukeggchapman could do another rebase on top of master, then that would ease my burden. |
Author
|
I started rebasing, but there has been a lot of whitespace changes in master which made the rebase more time consuming and I just don't have time to go through it at the moment. |
|
Considering the history of this PR it doesn't seem like we'll be getting it any time soon. Has anybody come up with alternative solutions for this problem? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a rebase of #893 (from restangular 1.4.0 to ~1.5.2) and resolves issue #891