Skip to content

Deprecate metro code #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
horgh merged 1 commit into from
Jan 13, 2025
Merged

Deprecate metro code #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

* Ruby 3.0+ is now required. If you're using Ruby 2.5, 2.6, or 2.7, please
use version 1.2.0 of this gem.
* Deprecated `metro_code` on `MaxMind::GeoIP2::Record::Location`. The code
values are no longer being maintained.

## 1.2.0 (2023-12-04)

Expand Down
6 changes: 3 additions & 3 deletions lib/maxmind/geoip2/record/location.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ def longitude
get('longitude')
end

# The metro code of the location if the location is in the US. MaxMind
# returns the same metro codes as the Google AdWords API. See
# https://developers.google.com/adwords/api/docs/appendix/cities-DMAregions.
# The metro code is a no-longer-maintained code for targeting
# advertisements in Google.
#
# @return [Integer, nil]
# @deprecated Code values are no longer maintained.
def metro_code
get('metro_code')
end
Expand Down
Loading