Improve HTTP Client structure

[mathleite]

No description provided.

[deenison]

Not sure if Adapter in the name is really necessary - (this is not a change request)

[deenison]

It would be more appropriated to have HttpClient instead of just Client as subdomain, because Client alone doesn't mean much, opposed as HttpClient

[deenison]

Otherwise will leave the impression those are NotificationClients instead

[deenison]

Suggested change

	private HttpClientAdapterInterface $client;
	private HttpClientAdapterInterface $httpClient;

[deenison]

Suggested change

	public function __construct(HttpClientAdapterInterface $client, string $message, string $messageType)
	public function __construct(HttpClientAdapterInterface $httpClient, string $message, string $messageType)

[deenison]

Suggested change

	namespace App\Notification\Client\Guzzle;
	namespace App\Notification\HttpClient\Adapter;

[deenison]

This namespace doesn't match the file structure.

Suggested change

	use App\Notification\Client\HttpClientAdapterInterface;
	use App\Notification\HttpClientAdapterInterface;

[deenison]

Suggested change

	private Client $client;
	private Client $guzzle;

[deenison]

It seems at the moment there is no test for this class

[deenison]

This change doesn't belong to the main intent of this PR. A more appropriated approach would be to split things up.:

1. we put this PR on hold
2. create a PR fixing the issue
3. Once it got merged, we get back here, rebase and re-send it

[deenison]

It seems Fake is actually a "concrete" application subdomain. This may be very misleading.

An approach to get it clear up, is to have a test-subdomain called Support:

tests/
  app/
    ...  
  support/
    Notification/
      HttpClient/
        Adapter/
          FakeHttpClient.php
    ...

and then pointing it out on composer.json:

"autoload-dev": {
  "psr-4": {
    "App\\Test\\": "tests/app",
    "App\\Test\\Support\\": "tests/support"
  }
}

(perhaps "Test" should be the first term, actually - but this is for another discussion in another time)

[deenison]

You need to establish a pattern/consistency regarding the application files structure - tabs vs spaces, how many, blank lines between <?php and namespace statements, etc :)

There a lot of variations it seems.

I'd suggest you take a look on https://editorconfig.org