-
Notifications
You must be signed in to change notification settings - Fork 64
independence, expectation of product #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Maybe it is better to rename |
0895272 to
bc59196
Compare
538b914 to
d32696d
Compare
t6s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed lines 0 -- 878 and quickly looked through 879-.
The latter things need some cleaning.
0ab14bf to
a1eb371
Compare
aabd8b3 to
a811b46
Compare
a93338c to
1c8f2b0
Compare
ee254fb to
215f186
Compare
fffdf70 to
28b1e65
Compare
|
I forgot the context for this draft PR. What is the current status? |
- fix changelog - mv defs to appropriate files
28b1e65 to
b6c474c
Compare
Rebased but for reasons I forgot some things look duplicated in |
|
I removed duplicates and unused lemmas and did some cleaning. |
theories/numfun.v
Outdated
| Lemma funrD_Dpos f g : f \+ g = (f \+ g)^\+ \- (f \+ g)^\-. | ||
| Proof. | ||
| apply/funext => x; rewrite /funrpos /funrneg/=; have [|/ltW] := lerP 0 (f x + g x). | ||
| - by rewrite -{1}oppr0 -lerNl => /max_idPr ->; rewrite subr0. | ||
| - by rewrite -{1}oppr0 -lerNr => /max_idPl ->; rewrite opprK add0r. | ||
| Qed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lemma should be removed as it is just an instance of funrposneg above.
theories/numfun.v
Outdated
| - by rewrite -{1}oppr0 -lerNr => /max_idPl ->; rewrite opprK add0r. | ||
| Qed. | ||
|
|
||
| Lemma funrD_posD f g : f \+ g = (f^\+ \+ g^\+) \- (f^\- \+ g^\-). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one, on the other hand, is nontrivial and should be kept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the name looks bad and I have no good suggestion for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
funrD_posBneg would be better.
This can be seen as a form of distributivity where ^\+ and ^\- parallelly distributes over \+ inside
expressions of the form _^\+ \- _^\-. I do not know how to name it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact this lemma has a short proof once one observes that it almost corresponds to interchange with addition and subtraction (most if not all uses of interchange in MathComp use twice the same operator). interchange lemmas are suffixed with ACA like addrACA but that might be an overkill here to abide by this naming scheme because we mix two operators and moreover on functions (calling for a fctE suffix) so maybe addBr could be enough to suggests interchange sub add and therefore the name could just be funrDB (and funeDB for the corresponding lemmas for extended real numbers).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interchange is indeed another structure involved here, and I also thought about incorporating ACA in its name, though not coming up with a tidy result.
funrDB is neat but looks a bit too stripped off since it does not clearly indicate that it is about ^+ and ^-.
I am however not sure how to restore that info without elongating the name, and weakly approving funrDB.
t6s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed lines 0 -- 878 and quickly looked through 879-. The latter things need some cleaning.
It looks like I reviewed independence.v once, and the file looks not so bad. @hoheinzollern can you double check?
I have read the other files and put some comments requesting some changes.
Thanks for the comments that triggered very welcomed improvements. |
| Local Open Scope ereal_scope. | ||
|
|
||
| Definition independent_events (I : set I0) (E : I0 -> set T) := | ||
| (forall i, I i -> measurable (E i)) /\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is measurability built in independence of variables? I would have expected measurability to be a side condition. (Same remark in each definition below)
Motivation for this change
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Reminder to reviewers