Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on refactoring the import paths and simplifying the code in multiple files within the
mapillary_toolsmodule. The main changes involve moving thesimple_mp4_parserandmp4_sample_parserto a newmp4directory, updating the import paths accordingly, and refactoring methods to improve readability and maintainability.Refactoring and Import Path Updates:
mapillary_tools/geotag/blackvue_parser.py: Updated import paths to use the newmp4module and refactored the usage ofsimple_mp4_parsertosparser. [1] [2] [3]mapillary_tools/geotag/camm_builder.py: Movedconstruct_mp4_parserandmp4_sample_parserimports to themp4module.mapillary_tools/geotag/camm_parser.py: Updated import paths and refactored methods to use the newsparserandsample_parserfrom themp4module. [1] [2] [3] [4] [5] [6] [7] [8]mapillary_tools/geotag/geotag_videos_from_video.py: Updated import paths to use the newsparserfrom themp4module. [1] [2] [3] [4]mapillary_tools/geotag/gpmf_parser.py: Removed thesimple_mp4_parserimport and updated methods to use the newsample_parserfrom themp4module. [1] [2] [3] [4] [5] [6] [7]Code Simplification:
mapillary_tools/geotag/simple_mp4_builder.py: Updated variable naming conventions and added comments to improve code readability. [1] [2] [3]These changes aim to make the codebase more modular and easier to maintain by organizing related functionalities into a dedicated
mp4module and improving the clarity of the code with better naming conventions and comments.