Skip to content

fix: update laserstream dep to fix connection leak#1065

Merged
thlorenz merged 4 commits intomasterfrom
thlorenz/helius-fix
Mar 19, 2026
Merged

fix: update laserstream dep to fix connection leak#1065
thlorenz merged 4 commits intomasterfrom
thlorenz/helius-fix

Conversation

@thlorenz
Copy link
Collaborator

@thlorenz thlorenz commented Mar 17, 2026

Summary

Update helius-laserstream dependency to a version that fixes the gRPC connection leak.
The upstream fix ensures that when a StreamHandle is dropped, the underlying gRPC connection is properly
aborted via a watch channel close signal, preventing leaked connections from accumulating.

Details

The helius-laserstream git dependency branch was changed from v0.2.2-magicblock to v0.2.2-magicblock+conn-fix.
The upstream fix (in laserstream-sdk) adds a watch::Sender<bool> to StreamHandle whose
Drop impl signals the background stream task to shut down gracefully. This prevents orphaned
gRPC connections when the handle goes out of scope.

Summary by CodeRabbit

  • Chores
    • Updated the helius-laserstream dependency to a newer upstream revision. This is an internal dependency update to bring in upstream fixes and improvements; no user-facing features were added and no manifest entries beyond the dependency were changed.

@github-actions
Copy link

github-actions bot commented Mar 17, 2026

Manual Deploy Available

You can trigger a manual deploy of this PR branch to testnet:

Deploy to Testnet 🚀

Alternative: Comment /deploy on this PR to trigger deployment directly.

⚠️ Note: Manual deploy requires authorization. Only authorized users can trigger deployments.

Comment updated automatically when the PR is synchronized.

@thlorenz thlorenz requested a review from GabrielePicco March 17, 2026 09:34
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 02e8490c-3a15-4ed7-8619-cc4e965ca112

📥 Commits

Reviewing files that changed from the base of the PR and between ab9f60d and a8c9a49.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml

📝 Walkthrough

Walkthrough

The helius-laserstream dependency in Cargo.toml under [workspace.dependencies] was updated: the branch value changed from v0.2.2-magicblock to v0.2.2-magicblock+conn-fix. The git URL (https://github.com/magicblock-labs/laserstream-sdk) remained unchanged. This is a one-line change in the dependency manifest.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch thlorenz/helius-fix
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

@thlorenz thlorenz marked this pull request as ready for review March 19, 2026 04:05
@thlorenz thlorenz enabled auto-merge (squash) March 19, 2026 08:32
@thlorenz thlorenz merged commit 0d3eb60 into master Mar 19, 2026
18 checks passed
@thlorenz thlorenz deleted the thlorenz/helius-fix branch March 19, 2026 09:32
thlorenz added a commit that referenced this pull request Mar 19, 2026
* master:
  fix: update laserstream dep to fix connection leak (#1065)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants