Changed testcase properties to use Label to match mstest filter format #175
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentleungrsm
changed the title
jsskeen-utah
reviewed
Jan 8, 2026
|
|
||
| private readonly Dictionary<string, TestProperty> testCaseProperties = new Dictionary<string, TestProperty>(StringComparer.OrdinalIgnoreCase) | ||
| { | ||
| [TestCaseProperties.FullyQualifiedName.Id] = TestCaseProperties.FullyQualifiedName, |
There was a problem hiding this comment.
I'm not sure what the Id property has previously been used for. Does this have to be changed from Id to Label or could we include both? Perhaps you could link to the source of other test runners where they do the same thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously needed
dotnet test --filter "TestCase.FullyQualifiedName=FailingTest.When_adding_two_numbers::should_be_greater_than_ten"Now matches MSTest filter format
dotnet test --filter "FullyQualifiedName=FailingTest.When_adding_two_numbers::should_be_greater_than_ten"This is to solve failed mspec test re-runs not actually re-running via VSTest@2 in Azure DevOps. The re-run process automatically adds tests into the filter param using the latter format.