feat: add onPress event to Marker component#36
Merged
Conversation
Expose moveCamera through MapContext so Marker.web uses offsetCenter instead of raw panTo, matching MapView's moveCamera behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
onPressevent to the Marker component across all platforms (iOS Apple Maps, iOS Google Maps, Android Google Maps). The event includescoordinateandpointpayload matching the existingMapViewpress event shape. Also centers the camera on marker press for Apple Maps to match Google Maps default behavior.onPressfires withPressEventPayload(coordinate + screen point)onPresswhen tapping a marker (consistent with Google Maps)MAPVIEW.mdwith missing event props (onPress,onLongPress,onReady)Type of Change
Test Plan
onPressfires with coordinate/point, camera centers, maponPressdoes NOT fireonPressfires, default behavior preservedonPressfires, default behavior preservedonPressfires as beforeonPress→ default platform behavior unchangedChecklist