fix(docs): update function signature of request_key_builder#361
Open
HurSungYun wants to merge 1 commit intolong2ice:mainfrom
Open
fix(docs): update function signature of request_key_builder#361HurSungYun wants to merge 1 commit intolong2ice:mainfrom
request_key_builder#361HurSungYun wants to merge 1 commit intolong2ice:mainfrom
Conversation
mkdir700
approved these changes
Feb 2, 2024
Author
|
@long2ice can you please review this PR? thanks in advance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the function signature of
request_key_builderin the example is outdated.This PR updates the example to synchronize with the signature of default_key_builder available at:
fastapi-cache/fastapi_cache/key_builder.py
Line 8 in 91ba6d7