fix: license check in status tracker #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anisaoshafi
force-pushed
the
fix-license-check
branch
from
8207052 to
e51bbcf
Compare
skyrpex
approved these changes
Nov 7, 2025
Collaborator
skyrpex
left a comment
skyrpex
left a comment
There was a problem hiding this comment.
I love the solution. Great job :)
Do we want to add the min delay here, though?
Collaborator
Author
No we don't need it. mindelay was mostly about the setup phase so the progress messages could be visible for at least a moment if they were executed too quickly. Removed it, thank you! |
anisaoshafi
force-pushed
the
fix-license-check
branch
from
8c9dac0 to
48f5468
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We track license validity as part of the toolkit status trackers, which relies on
localstack license inforesponse.If one has not interacted with localstack instance (e.g. started localstack or used some service) for a day (which is the TTL of the license cache), the response will include
license validity: invalid.That causes licenseTracker to evaluate to "setup_required", which in turn evaluates the overall status of the toolkit to
setup_required.As a result, the setup wizard notification opens, which is not the right behaviour (screenshot attached).
To avoid this issue, we first activate the license (
localstack license activate), so it refreshes the license, before actually performing the validity check.[Note: Originally opened in this PR which had to be reverted to simplify unblocking main (because there was one commit previous to this).]