refactor(AWS-Proxy): Refactored AWS Proxy to use WebAppExtension pattern #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reports found out that when using the extension in the web application with dark theme is quite difficult to read what is going on
After little research I've found out that the extension does not use our WebApp pattern that not only fixes the issue but also provides other quality of life improvements, especially when displayed inside the WebApp.
What I did was mostly create a blank extension and adapting this one based on the setup of the blank one (that uses our react template)
This is the result AFTER the changes
I also took some liberties in refactoring a bit the UI
Todo
Before merging we still need to deploy a fix I've discovered in the web app for the integration package https://github.com/localstack/localstack-web/pull/2063
Note
After setting the env vars and the proxy config I could see the emulator saying that the proxy has started but from the UI it kept saying disabled... This is however in line on how it was working before so I beliee I didn't introduce any regressions... let me know if you want me to dig a bit deeper into this
Related
Closes BEE-262