Skip to content

Conversation

@italomiguelpinheiro
Copy link

@italomiguelpinheiro italomiguelpinheiro commented Jan 27, 2026

Summary by CodeRabbit

  • Refactor
    • Updated the internal initialization structure of video track components for improved code organization and maintainability.

Thir PR updates the LocalVideoTrack definition to carry an "@internal" annotation and match the LocalAudioTrack version.

✏️ Tip: You can customize this high-level summary in your review settings.

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

The LocalVideoTrack constructor is refactored from a private named constructor to an internal public constructor annotated with @internal, with all call sites updated from LocalVideoTrack._() to LocalVideoTrack() syntax. The parameter list and runtime behavior remain unchanged.

Changes

Cohort / File(s) Summary
Constructor Visibility Refactoring
lib/src/track/local/video.dart
Converted LocalVideoTrack._() private named constructor to @internal LocalVideoTrack() public constructor; updated all call sites for camera, screen-share, and screen-share-with-audio track creation to use the new syntax

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A constructor hops from shadows deep,
With @internal marks to secrets keep,
No longer private, yet still concealed—
A visibility dance revealed! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'fix: change local video track constructor' directly describes the main change: converting the LocalVideoTrack constructor from private to internal.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
lib/src/track/local/video.dart (1)

177-184: Update the constructor comment to reflect visibility

The comment says “Private constructor,” but the constructor is now public/internal, which can mislead readers.

💡 Suggested edit
-  // Private constructor
+  // Internal constructor (not part of public API)
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e421d4 and 9058504.

📒 Files selected for processing (1)
  • lib/src/track/local/video.dart
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Build for Flutter Web WASM
  • GitHub Check: Build for Flutter Windows
  • GitHub Check: Build for Flutter macOS
  • GitHub Check: Build for Flutter Linux
  • GitHub Check: Build for Flutter Web
  • GitHub Check: Build for Flutter iOS
  • GitHub Check: Build for Flutter Android
  • GitHub Check: Dart Analyze Check
  • GitHub Check: Dart Test Check
🔇 Additional comments (1)
lib/src/track/local/video.dart (1)

192-198: LGTM: constructor call sites updated consistently

All instantiations now use the new constructor while preserving parameter order and behavior.

Also applies to: 221-227, 250-256

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.

@italomiguelpinheiro italomiguelpinheiro changed the title Fix/change local video track constructor fix: change local video track constructor Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants