Add support and basic validation for uv_flags (#40) #41
+194
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+116
to
+123
| - `["--native-tls"]` - use the system's native TLS implementation instead | ||
| of vendored rustls. This is useful in corporate environments where the | ||
| system certificate store must be used. | ||
| - `["--no-cache"]` - disable the cache, forcing a fresh download of all | ||
| packages. | ||
| - `["--reinstall"]` - force reinstallation of all packages, even if they | ||
| are already present. | ||
| - `["--quiet"]` - suppress output from the uv command. |
Member
There was a problem hiding this comment.
I would prefer to just have an Elixir option :native_tls. This way we have more control over where how and where we pass specific CLI options. Also, we already have :force, so no need to use --no-cache or --reinstall. @josevalim wdyt?
Contributor
There was a problem hiding this comment.
I think I agree, as we cannot guarantee all of the options will work with Pythonx...
Author
There was a problem hiding this comment.
Are there other options you would want as part of this PR or just limit it to :native_tls?
Member
There was a problem hiding this comment.
Let's do native tls for now. We can add more options if someone has a need for it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support and a bit of validation and tests.
Let me know if you want something different.