Increased heap performance for Encoding.#3
Open
Cipherwraith wants to merge 3 commits intolitherum:masterfrom
Open
Increased heap performance for Encoding.#3Cipherwraith wants to merge 3 commits intolitherum:masterfrom
Cipherwraith wants to merge 3 commits intolitherum:masterfrom
Conversation
Author
|
My understanding of the punycode algorithm itself is still quite limited, so I didnt attempt an algorithm refactoring -- lets leave that up the mathematicians. |
Author
|
Now I have this patch in production running millions of times per second and have no more performance issues. |
Owner
|
I’m no longer interested in maintaining this package. Do you want to become the maintainer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encode was eating my ram like crazy on a large data set, so I went through and made it stricter and a bit more performant. Its still not perfect, but I am seeing large performance gains for my data set with this patch.