[WIP] Added support for config file#412
[WIP] Added support for config file#412jay763190097 wants to merge 10 commits intolinuxmint:masterfrom
Conversation
|
Comments from a passerby who doesn't know much about the Timeshift source:
1 and 3 are big red flags to me. |
|
|
@RandallPittmanOrSt This PR is trying to implement the requirement for #348 #357 #198. |
|
Hi, I'm good with adding a way to specify a config file, but this PR seems to be doing a number of other things:
Thanks |
|
Hi @mtwebster
May need your advice for the last item, caused that i want to add the below environment parameter and the previous one doesn't work for me. If I just run this command from timeshift-launcher file 
We can see the pkexec path is wrong, it doesn't match <annotate key="org.freedesktop.policykit.exec.path">/usr/bin/timeshift-gtk</annotate> |
@mtwebster @RandallPittmanOrSt All items are done, Pls help to check. |
|
@mtwebster Hey, May I know when do we plan to merge this PR. |
| if (entry.mount_point.has_prefix("/srv")){ continue; } | ||
| if (entry.mount_point.has_prefix("/sys")){ continue; } | ||
| if (entry.mount_point.has_prefix("/system")){ continue; } | ||
| if (entry.mount_point.has_prefix("/work")){ continue; } |
There was a problem hiding this comment.
This isn't a standard folder, remove please
| * Added supported for multiple configuration files | ||
|
|
||
| -- Jiang Meng(Jay) <jiangmang.1992@163.com> Tue, 03 Jun 2025 23:15:15 +0000 | ||
|
|
There was a problem hiding this comment.
Don't modify the changelog, this is done at release time.
| help2man \ | ||
| gettext \ | ||
| valac \ | ||
| libvala-dev \ |
There was a problem hiding this comment.
This shouldn't be necessary to build.
|
#460 was merged, you can just drop the timeshift-launcher changes altogether. |
clefebvre
changed the title
5 participants
No description provided.