increase timeout in ipts_control_wait_flush#32
Open
Leo1998 wants to merge 1 commit intolinux-surface:masterfrom
Open
increase timeout in ipts_control_wait_flush#32Leo1998 wants to merge 1 commit intolinux-surface:masterfrom
Leo1998 wants to merge 1 commit intolinux-surface:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a rare issue on my Surface Pro 5 (Arch Linux). Happens about every tenth boot.
log: dmesg.txt
As far as i debugged this, the module switches the mode from event to poll (see
ipts_eds1_switch_mode) thus callingipts_control_restart. During shutdown theIPTS_CMD_QUIESCE_IOcommand sometimes times out inipts_control_wait_flushreturningEAGAIN(-11).If the module tries to start again, the device is still "flushing" leading to the failure in
ipts_control_get_device_info, which obviously makes the touchscreen not working.Increasing the timeout in
ipts_control_wait_flushto 10 sec fixes this on my device, but maybe you have a nicer solution?? Alternatively we could increase themsleeptimeout inipts_control_restartbut i think this PR should be the better option.