drbd: always set BLK_FEAT_STABLE_WRITES #547
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: f14faaf |
Author
|
Upstream branch: f14faaf |
blktests-ci
bot
force-pushed
the
series/1051265=>linus-master
branch
from
de8ac99 to
c7e8199
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
7c2ae0a to
54294d6
Compare
Author
|
Upstream branch: b7ff715 |
blktests-ci
bot
force-pushed
the
series/1051265=>linus-master
branch
from
c7e8199 to
2140b96
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
54294d6 to
eb49f7b
Compare
Author
|
Upstream branch: e7aa572 |
blktests-ci
bot
force-pushed
the
series/1051265=>linus-master
branch
from
2140b96 to
252a8ea
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
eb49f7b to
30e5c22
Compare
Author
|
Upstream branch: 05f7e89 |
DRBD requires stable pages because it may read the same bio data multiple times for local disk I/O and network transmission, and in some cases for calculating checksums. The BLK_FEAT_STABLE_WRITES flag is set when the device is first created, but blk_set_stacking_limits() clears it whenever a backing device is attached. In some cases the flag may be inherited from the backing device, but we want it to be enabled at all times. Unconditionally re-enable BLK_FEAT_STABLE_WRITES in drbd_reconsider_queue_parameters() after the queue parameter negotiations. Also, document why we want this flag enabled in the first place. Fixes: 1a02f3a ("block: move the stable_writes flag to queue_limits") Signed-off-by: Christoph Böhmwalder <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]>
blktests-ci
bot
force-pushed
the
series/1051265=>linus-master
branch
from
252a8ea to
59bb28c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: drbd: always set BLK_FEAT_STABLE_WRITES
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1051265