Fixed test_disk_resize_clone_and_create failure#866
Open
ezilber-akamai wants to merge 1 commit intolinode:devfrom
Open
Fixed test_disk_resize_clone_and_create failure#866ezilber-akamai wants to merge 1 commit intolinode:devfrom
test_disk_resize_clone_and_create failure#866ezilber-akamai wants to merge 1 commit intolinode:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Linode disk integration tests to make test_disk_resize_clone_and_create reliable by selecting an appropriate disk to resize and by adding readiness polling/retries to reduce flakiness.
Changes:
- Add helper logic to pick the smallest disk (typically swap) instead of attempting to shrink the OS disk.
- Add explicit waits for disk availability/“ready” state and verify the resized size is reflected before continuing.
- Increase retry counts/delays for disk resize/clone operations and for Linode shutdown in the disk-test fixture.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/integration/linodes/test_disk.py |
Selects the smallest disk for resize/clone and adds readiness/size polling plus more retries to prevent the test from racing disk state transitions. |
tests/integration/linodes/fixtures.py |
Makes Linode shutdown in the disk-test fixture more resilient by adding retries/delay before waiting for offline status. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ezilber-akamai
requested review from
jriddle-linode and
mgwoj
and removed request for
a team
ezilber-akamai
added
the
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fixed
test_disk_resize_clone_and_createfailure✔️ How to Test
make test-int TEST_CASE=test_disk_resize_clone_and_create