vz: Fix scrollbar issue with runtime swizzle #4476
Open
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Code-Hex/vz library wraps VZVirtualMachineView in an NSScrollView with scrollbars hardcoded to YES (for their zoom feature). This causes ~16px of the VM display to be cut off by scrollbar gutters. This patch uses Objective-C method swizzling to intercept NSScrollView's setDocumentView: method and disable scrollbars when the document view is a VZVirtualMachineView. This is a self-contained fix that doesn't require forking the vz library. Signed-off-by: stuffbucket <[email protected]>
Author
|
Adding images showing the behavior with the scrollbars. In the lower left there is some text that is occluded by the scroll. The scrollbars are not shown relative to the size of the desktop or display, they're hardcoded to be shown all the time. In the console case this seems to not create a problem, but in the desktop case it definitely does. 
|
AkihiroSuda
reviewed
Dec 19, 2025
| // a VZVirtualMachineView. | ||
| // | ||
| // This is a temporary workaround until Code-Hex/vz adds a configuration option | ||
| // to disable scrollbars. See: https://github.com/Code-Hex/vz/issues/XXX |
AkihiroSuda
reviewed
Dec 19, 2025
| } | ||
|
|
||
| // Constructor attribute ensures this runs before main() | ||
| // This patches NSScrollView before Code-Hex/vz creates any windows |
Member
There was a problem hiding this comment.
Not a fan of monkey patching AppKit, could this be fixed in Code-Hex/vz ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Code-Hex/vz library wraps VZVirtualMachineView in an NSScrollView with scrollbars hardcoded to YES (for their zoom feature). This causes ~16px of the VM display to be cut off by scrollbar gutters.
This patch uses Objective-C method swizzling to intercept NSScrollView's setDocumentView: method and disable scrollbars when the document view is a VZVirtualMachineView.
This is a self-contained fix that doesn't require forking the vz library or add any dependencies.
Tested successfully on macOS 26.2 (see screenshot) with Debian 13 (Plasma) and Alpine (serial console).