Bump ldk-node to latest main #93
Merged
+65
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to ldk-node git rev d1bbf978 which requires passing NodeEntropy explicitly to the builder. Also adds handling for new NodeError variants HrnParsingFailed and InvalidScriptPubKey. Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
👋 Thanks for assigning @benthecarman as a reviewer! |
tnull
approved these changes
Jan 13, 2026
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Not opposed, though I'll leave it to Ben to decide.
It might become more complicated if Server would ever want to take a dependency on rust-lightning or bitcoin-payment-instructions directly, though we probably don't want to do that but rather use LDK Node's crate re-exports anyways.
benthecarman
approved these changes
Jan 13, 2026
Collaborator
benthecarman
left a comment
benthecarman
left a comment
There was a problem hiding this comment.
Yeah I don't imagine we will have any conflicts with deps, we should be able to get everything from ldk-node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns ldk-server with ldk-node's own approach of tracking upstream main rather than releases.