Merged
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
chuksys
reviewed
Jan 6, 2026
Contributor
chuksys
left a comment
chuksys
left a comment
There was a problem hiding this comment.
Thanks for the follow-up 🙏. Just a few observations.
tnull
force-pushed
the
2026-01-bitcoin-payment-instructions-follow-up
branch
3 times, most recently
from
6ff2d7f to
aff52a5
Compare
chuksys
approved these changes
Jan 7, 2026
tankyleo
reviewed
Jan 7, 2026
src/payment/unified.rs
Outdated
|
|
||
| /// A payment handler allowing to create [BIP 21] URIs with an on-chain, [BOLT 11], and [BOLT 12] payment | ||
| /// option. | ||
| /// A payment handler that supports creating and paying to [BIP 21] URIs with an on-chain, [BOLT 11], |
Contributor
There was a problem hiding this comment.
nit: "with on-chain" for consistency
Collaborator
Author
There was a problem hiding this comment.
Ah, right, that slipped through:
> git diff-tree -U2 aff52a58 8f63a279
diff --git a/src/payment/unified.rs b/src/payment/unified.rs
index 3184c847..671af14f 100644
--- a/src/payment/unified.rs
+++ b/src/payment/unified.rs
@@ -47,5 +47,5 @@ struct Extras {
}
-/// A payment handler that supports creating and paying to [BIP 21] URIs with an on-chain, [BOLT 11],
+/// A payment handler that supports creating and paying to [BIP 21] URIs with on-chain, [BOLT 11],
/// and [BOLT 12] payment options.
///
tnull
force-pushed
the
2026-01-bitcoin-payment-instructions-follow-up
branch
from
aff52a5 to
8f63a27
Compare
tankyleo
reviewed
Jan 8, 2026
Contributor
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
LGTM, we'll need a rebase before merge
tnull
force-pushed
the
2026-01-bitcoin-payment-instructions-follow-up
branch
from
8f63a27 to
675d644
Compare
.. as otherwise we might wait indefinitely for a service to respond.
tnull
force-pushed
the
2026-01-bitcoin-payment-instructions-follow-up
branch
from
675d644 to
b167ef6
Compare
tankyleo
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We make some minor adjustments after #666 landed.
(cc @chuksys)