test: add gossip_proposer_attestation=True to fix test_reorg_on_newly_justified_slot#457
Merged
unnawut merged 3 commits intoleanEthereum:mainfrom Mar 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
A test vector (test_reorg_on_newly_justified_slot) is still failing even after the key regen in #455. This is caused by a spec's behavior change in #449 where we no longer embed the proposer's attestation as part of the block proposal (they're now gossiped like non-proposer's attestations) so a block proposal no longer carries 1 attestation weight from the proposer so fork A never gets any fork choice weight (so it was using lexicographical order hence the random pass/failure).
This PR is a quick fix to get the test vectors working again. A better solution might be to make
gossip_proposer_attestation=Truethe default behavior for all test cases but that's a much bigger change.✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox