feat: strengthen typing and remove suppressions#451
Merged
tcoratger merged 1 commit intoleanEthereum:mainfrom Mar 11, 2026
Merged
feat: strengthen typing and remove suppressions#451tcoratger merged 1 commit intoleanEthereum:mainfrom
tcoratger merged 1 commit intoleanEthereum:mainfrom
Conversation
- Replaced '# type: ignore' suppressions in discovery transport with 'assert isinstance' guards - Removed hasattr defensive checks in node.py (Checkpoint.root is Bytes32, always provides .hex()) - Narrowed Coroutine[Any, Any, None] to Coroutine[None, None, None] in sync service and removed typing.Any import - Updated unit test mocks to provide spec matching assertions
tcoratger
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a pure cleanup pass that strengthens typing and removes
# type: ignoresuppressions across three modules, making the code more Pythonic without introducing any behavioral changes.Changes made
# type: ignore[assignment]suppressions with explicitassert isinstance(x, asyncio.DatagramTransport)type narrowing guards in transport.py. This ensures it fails fast if an unexpected transport type is received.hasattrchecks) in node.py.Checkpoint.rootis explicitly typed asBytes32, which always provides.hex().Coroutine[Any, Any, None]toCoroutine[None, None, None]in service.py, since these coroutines are never.send()-ed into.typing.Anyimport.Verification
uvx tox -e all-checkspasses successfully (formatting, linting, MyPy check).uvx tox -e pytest(full suite of 2,672 tests) passes successfully with no regressions.