Open
Conversation
3 tasks
g11tech
reviewed
Mar 11, 2026
| return | ||
| sorted_proofs = sorted( | ||
| proofs, | ||
| key=lambda proof: len(proof.participants.to_validator_indices()), |
Contributor
There was a problem hiding this comment.
calc and sort them here with participants - covered directly, this is what really will give greedy coverage which imo would be the best coverage algo on average
g11tech
reviewed
Mar 11, 2026
| return self.model_copy(update={"safe_target": safe_target}) | ||
|
|
||
| def aggregate_committee_signatures(self) -> tuple["Store", list[SignedAggregatedAttestation]]: | ||
| def aggregate_committee_signatures_and_payloads(self) -> tuple["Store", list[SignedAggregatedAttestation]]: |
Contributor
There was a problem hiding this comment.
Suggested change
| def aggregate_committee_signatures_and_payloads(self) -> tuple["Store", list[SignedAggregatedAttestation]]: | |
| def aggregate_signatures_and_payloads(self) -> tuple["Store", list[SignedAggregatedAttestation]]: |
g11tech
reviewed
Mar 11, 2026
|
|
||
| def aggregate( | ||
| self, | ||
| attestations: Collection[Attestation], |
Contributor
There was a problem hiding this comment.
it needs to take attestation/attestation data as the params
g11tech
reviewed
Mar 11, 2026
| # Use only keys from new_payloads and gossip_signatures | ||
| # know_payloads can be used to extend the proof with new_payloads and gossip_signatures | ||
| # but known_payloads are not recursively aggregated into their own proofs | ||
| attestation_keys = set(new_payloads.keys()) | set(gossip_signatures.keys()) |
Contributor
There was a problem hiding this comment.
new payloads are use for aggregator and it can extend with known payloads if the validator indices in attestations for a particular data is not covered.
and known payloads are used for block proposer which will already have new payloads merged in and shouldn't require a lookup in new payloads (which should be an error condition)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Implements recursive aggregation. Spec for devnet-4 (draft):
🔗 Related Issues or PRs
✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox