luks-list: show tang key thumbprints

[rpigott]

Implements #351, adding the thp to the list output. The displayed thp can be used to fetch the specific stored key from the tang server at GET /adv/<thp>.

[rpigott]

Sadly this disturbs the pin cfg in clevis luks regen.

[rpigott]

Ok should work now. I changed it to print the thumbprint only with a "-t" argument.

[sarroutbi]

Hello. Thanks for your change. Changes LGTM. Could you please complete your commit to:

• Include format changes to man page? File: ./src/luks/clevis-luks-list.1.adoc
• Include a unit test to verify this new parameter works as expected?

Thanks

[sergio-correia]

This is not correct, as you will get thumbprints for both the exchange and signing keys. You should do something like tang-show-keys [1] does, with the jose jwk use -u verify, before getting the thumbprints.

It may be good to also specify the default hash algorithm for the thumbprints.

[1] https://github.com/latchset/tang/blob/master/src/tang-show-keys#L34

[sarroutbi]

Hello @rpigott. May I help you uploading proposed changes?

[rpigott]

Hi, thanks for the feedback but I actually have no use for this feature anymore, so I don't really care about the patch. If you or anyone else still want this feature feel free to use or modify the patch as you see fit.

[sarroutbi]

@sergio-correia : do you think this is useful? Do you want me to recover it from here?