Change split_single_document to work on STDIN & STDOUT#31
Open
jelmervdl wants to merge 1 commit intokpu:masterfrom
Open
Change split_single_document to work on STDIN & STDOUT#31jelmervdl wants to merge 1 commit intokpu:masterfrom
jelmervdl wants to merge 1 commit intokpu:masterfrom
Conversation
In b64 mode it still buffers the output and encodes it in one go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single document splitting just directly goes from Perl's STDIN to STDOUT now. In multidoc mode I locally override STDIN and STDOUT to point to variables.
I still buffer a single document in multidoc mode because I didn't see an easy way to stream base64 without re-implementing base64-encode in Perl. Piping it through
base64withopen()would work, but that would entail forking for every document.Fixes #30. Also fixes a warning printed by
$text = $text.$words[$i]when dealing with an empty line in-kmode.