Skip to content

Conversation

@LeoWoerteler
Copy link
Contributor

DEVOPS-3612 (Incremental Version Bumps for 5.10)

Copilot AI review requested due to automatic review settings December 25, 2025 22:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs incremental version bumps from 5.9.0 to 5.10.0 across OSGi manifest and feature files to align with the upcoming 5.10.0 release. The changes update bundle versions and dependency version ranges to maintain consistency across the KNIME Python 3 integration modules.

Key changes:

  • Updated bundle versions from 5.9.0 to 5.10.0 in manifest and feature files
  • Updated dependency version ranges for core KNIME bundles from [5.9.0,6.0.0) to [5.10.0,6.0.0)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
org.knime.python3.nodes/META-INF/MANIFEST.MF Updated bundle version and five dependency version ranges (core, core.ui, conda.envbundling, ext.svg, workflowservices, gateway.impl) from 5.9.0 to 5.10.0
org.knime.features.python3.nodes/feature.xml Updated feature version from 5.9.0 to 5.10.0
Comments suppressed due to low confidence (1)

org.knime.python3.nodes/META-INF/MANIFEST.MF:1

  • Several dependency version ranges were not updated from 5.9.0 to 5.10.0, creating an inconsistent version policy. All KNIME-internal dependencies (org.knime.* bundles) should have their lower bounds updated to 5.10.0 to match the bundle's own version and the updated dependencies (core, core.ui, conda.envbundling, ext.svg, workflowservices, gateway.impl). This includes: org.knime.python3, org.knime.python3.scripting, org.knime.python3.arrow, org.knime.scripting.editor, org.knime.core.table, org.knime.core.columnar, org.knime.core.data.columnar, org.knime.core.columnar.arrow, org.knime.conda, org.knime.python3.views, org.knime.credentials.base, and org.knime.credentials.base.oauth.
Manifest-Version: 1.0

org.knime.conda.envbundling;bundle-version="[5.9.0,6.0.0)",
org.knime.conda.envbundling;bundle-version="[5.10.0,6.0.0)",
org.knime.conda;bundle-version="[5.9.0,6.0.0)",
com.google.gson;bundle-version="[2.13.2,3.0.0)",
Copy link

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several dependency version ranges were not updated from 5.9.0 to 5.10.0, creating an inconsistent version policy. All KNIME-internal dependencies (org.knime.* bundles) should have their lower bounds updated to 5.10.0 to match the bundle's own version and the updated dependencies (core, core.ui, conda.envbundling, ext.svg, workflowservices, gateway.impl). This includes: org.knime.python3, org.knime.python3.scripting, org.knime.python3.arrow, org.knime.scripting.editor, org.knime.core.table, org.knime.core.columnar, org.knime.core.data.columnar, org.knime.core.columnar.arrow, org.knime.conda, org.knime.python3.views, org.knime.credentials.base, and org.knime.credentials.base.oauth.

Copilot uses AI. Check for mistakes.
Comment on lines 34 to 35
org.knime.credentials.base;bundle-version="[5.9.0,6.0.0)",
org.knime.credentials.base.oauth;bundle-version="[5.9.0,6.0.0)",
Copy link

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several dependency version ranges were not updated from 5.9.0 to 5.10.0, creating an inconsistent version policy. All KNIME-internal dependencies (org.knime.* bundles) should have their lower bounds updated to 5.10.0 to match the bundle's own version and the updated dependencies (core, core.ui, conda.envbundling, ext.svg, workflowservices, gateway.impl). This includes: org.knime.python3, org.knime.python3.scripting, org.knime.python3.arrow, org.knime.scripting.editor, org.knime.core.table, org.knime.core.columnar, org.knime.core.data.columnar, org.knime.core.columnar.arrow, org.knime.conda, org.knime.python3.views, org.knime.credentials.base, and org.knime.credentials.base.oauth.

Copilot uses AI. Check for mistakes.
@LeoWoerteler LeoWoerteler force-pushed the todo/DEVOPS-3612-incremental-version-bumps-fo branch from ad3a97d to 8a8116c Compare January 5, 2026 15:59
Copilot AI review requested due to automatic review settings January 9, 2026 16:25
@LeoWoerteler LeoWoerteler force-pushed the todo/DEVOPS-3612-incremental-version-bumps-fo branch from 8a8116c to 838a745 Compare January 9, 2026 16:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

org.knime.python3.nodes/META-INF/MANIFEST.MF:15

  • The org.knime.python3.arrow and org.knime.python3.arrow.types dependency version ranges remain at 5.9.0 while other related python3 module dependencies were updated. For consistency across python3 modules in this release, these should be updated to [5.10.0,6.0.0).
 org.knime.python3.arrow;bundle-version="[5.9.0,6.0.0)",

org.knime.core.ui;bundle-version="[5.10.0,6.0.0)",
com.fasterxml.jackson.core.jackson-databind;bundle-version="[2.12.1,3.0.0)",
com.fasterxml.jackson.core.jackson-core;bundle-version="[2.12.1,3.0.0)",
org.knime.python3;bundle-version="[5.9.0,6.0.0)",
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The org.knime.python3 dependency version range was not updated to 5.10.0 while other core dependencies were updated. For consistency in version requirements across related bundles in the same release, this should be updated to [5.10.0,6.0.0).

Suggested change
org.knime.python3;bundle-version="[5.9.0,6.0.0)",
org.knime.python3;bundle-version="[5.10.0,6.0.0)",

Copilot uses AI. Check for mistakes.
org.knime.core.columnar;bundle-version="[5.9.0,6.0.0)",
org.knime.core.data.columnar;bundle-version="[5.9.0,6.0.0)",
org.knime.core.table;bundle-version="[5.9.0,6.0.0)",
org.knime.core.columnar.arrow;bundle-version="[5.9.0,6.0.0)",
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The org.knime.core.columnar.arrow dependency version range was not updated to 5.10.0 while org.knime.core and org.knime.core.ui were updated. For consistency with other core module version requirements, this should be updated to [5.10.0,6.0.0).

Suggested change
org.knime.core.columnar.arrow;bundle-version="[5.9.0,6.0.0)",
org.knime.core.columnar.arrow;bundle-version="[5.10.0,6.0.0)",

Copilot uses AI. Check for mistakes.
org.yaml.snakeyaml;bundle-version="[2.4.0,3.0.0)",
org.knime.conda.envbundling;bundle-version="[5.9.0,6.0.0)",
org.knime.conda.envbundling;bundle-version="[5.10.0,6.0.0)",
org.knime.conda;bundle-version="[5.9.0,6.0.0)",
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The org.knime.conda dependency version range remains at 5.9.0 while org.knime.conda.envbundling was updated to 5.10.0. For consistency across conda-related dependencies, this should be updated to [5.10.0,6.0.0).

Suggested change
org.knime.conda;bundle-version="[5.9.0,6.0.0)",
org.knime.conda;bundle-version="[5.10.0,6.0.0)",

Copilot uses AI. Check for mistakes.
org.knime.conda.envbundling;bundle-version="[5.10.0,6.0.0)",
org.knime.conda;bundle-version="[5.9.0,6.0.0)",
com.google.gson;bundle-version="[2.13.2,3.0.0)",
org.knime.python3.views;bundle-version="[5.9.0,6.0.0)",
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The org.knime.python3.views and org.knime.python3.scripting.nodes.prefs dependency version ranges remain at 5.9.0 while other python3 modules are being updated. For consistency across python3 module dependencies in this release, these should be updated to [5.10.0,6.0.0).

Suggested change
org.knime.python3.views;bundle-version="[5.9.0,6.0.0)",
org.knime.python3.views;bundle-version="[5.10.0,6.0.0)",

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants