Fixed Python version support.#3283
Conversation
Remove conditional build argument for Python version >= 11
|
I haven't figured out yet if it's possible to somehow remove the dependency on sqlite (previously, you could blacklist sqlite in buildozer and p4a, but now my build crashes because of it) Sorry for such a large number of commits. I edited through GitHub Web and made a ton of mistakes... |
pythonforandroid/bootstraps/common/build/src/main/java/org/kivy/android/PythonUtil.java
Outdated
Show resolved
Hide resolved
Ensure patches and configure arguments are unique.
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Thanks for the bug fix and the follow ups.
I left two comments for the records, but nothing that absolutely needs to be addressed in this pull request.
| if _p_version.minor == 7: | ||
| self.patches.append("patches/py3.7.1_fix_cortex_a8.patch") |
There was a problem hiding this comment.
Nit: probably not needed anymore since we dropped that version
| elif _p_version.minor >= 8: | ||
| self.patches.append("patches/py3.8.1_fix_cortex_a8.patch") | ||
|
|
||
| self.patches = list(set(self.patches)) |
There was a problem hiding this comment.
Patching order is no longer preserved with the set, just something to have in mind in case patch depend on one another (which I'm not sure would be a good idea anyway)
4 participants
Fixed a bug when selecting libpythonХХХ.so version is decreasing (3.14 -> 3.5), but the check for the absence of the Python library ends at version 3.14, I changed it to 3.5. I also slightly changed the Python recipe to return support for version selection via buildozer