Add detailed diagnostics to SIARD XML validation errors#756
Draft
Copilot wants to merge 7 commits intodevelopmentfrom
Draft
Add detailed diagnostics to SIARD XML validation errors#756Copilot wants to merge 7 commits intodevelopmentfrom
Copilot wants to merge 7 commits intodevelopmentfrom
Conversation
… XML validation Co-authored-by: hmiguim <[email protected]>
…nErrorFormatter Co-authored-by: hmiguim <[email protected]>
Co-authored-by: hmiguim <[email protected]>
Co-authored-by: hmiguim <[email protected]>
Co-authored-by: hmiguim <[email protected]>
… SAX exception pattern Co-authored-by: hmiguim <[email protected]>
Copilot
AI
changed the title
[WIP] Improve validation diagnostics in MetadataXMLAgainstXSDValidator
Add detailed diagnostics to SIARD XML validation errors
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIARD XML validation failures reported only generic SAXException messages without location or context information, making debugging difficult.
Changes
New validation error infrastructure:
SiardValidationErrorHandler- Custom SAX ErrorHandler capturing errors with line/column numbers and error typesSiardValidationErrorFormatter- Extracts SIARD database context (schema/table/view) by parsing XML to error location using SAX Locator; reformats common XSD validation patterns into actionable messagesUpdated validators:
MetadataXMLAgainstXSDValidator(SIARD 2.1 and 2.2) to use custom ErrorHandlerError message transformation
Before:
After:
Pattern matching reformats:
Cannot find the declaration of element 'X'→Missing or undeclared element: 'X'Expected elements 'A B C'→Missing required element(s): A B CInvalid content...element 'X'→Invalid or unexpected element: 'X'Implementation notes
MAX_REPORTED_ERRORS = 5to prevent excessive message lengthOriginal prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.