SimpleForm: Allow mixed value on labels#93
Open
IvanCraft623 wants to merge 3 commits intojojoe77777:masterfrom
Open
SimpleForm: Allow mixed value on labels#93IvanCraft623 wants to merge 3 commits intojojoe77777:masterfrom
IvanCraft623 wants to merge 3 commits intojojoe77777:masterfrom
Conversation
Poggit-CI is enabled for this repo by @IvanCraft623 Visit the Poggit-CI page for this repo at https://poggit.pmmp.io/ci/IvanCraft623/FormAPI
This reverts commit dd9e510.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
This pull request will remove the limit for plugin developers to only set strings as labels.
Justification
In some cases, for example when the button references an object, it is necessary to make hacky or inefficient code to achieve the goal.
Example: A teleport form
Before:
After:
Backwards compatibility
This is technically BC Break as it requires at least PHP8, but since PM4 already requires PHP8 as a minimum there should be no problems.