-
-
Notifications
You must be signed in to change notification settings - Fork 107
Format to ruff specification #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
===========================================
- Coverage 100.00% 99.50% -0.50%
===========================================
Files 11 11
Lines 400 405 +5
Branches 68 54 -14
===========================================
+ Hits 400 403 +3
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. |
ulgens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support the goal of this PR but I think it's not likely that it will be merged. It's doing too many things at once. My recommendation would be to create the most basic ruff setup with ruff.toml in an initial PR, then follow it up with new PRs adding the rules and applying fixes.
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: astral-sh/ruff-action@v3 | ||
| with: | ||
| version: "latest" | ||
| - name: Ruff lint | ||
| run: ruff check --fix | ||
| - name: Ruff format | ||
| run: ruff format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend adding an action for pre-commit hooks, instead of a ruff-only config.
|
@mikemanger Would you mind rebasing this branch over #185 ? |
|
Superseded by the collection of following PRs: |
Most of the changes are import ordering and string concatenation changes but it has caught some exception issues, namely raising without a from inside an exception.