Skip to content

Conversation

@mikemanger
Copy link
Contributor

  • Replaces flake8 with ruff config and fixes issues
  • Fixes warning when compiling the documentation
  • Moves tox config to pyproject.toml

Most of the changes are import ordering and string concatenation changes but it has caught some exception issues, namely raising without a from inside an exception.

@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 98.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.50%. Comparing base (17fc0b6) to head (1ad8b6d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
django_hosts/__init__.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #174      +/-   ##
===========================================
- Coverage   100.00%   99.50%   -0.50%     
===========================================
  Files           11       11              
  Lines          400      405       +5     
  Branches        68       54      -14     
===========================================
+ Hits           400      403       +3     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ulgens ulgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support the goal of this PR but I think it's not likely that it will be merged. It's doing too many things at once. My recommendation would be to create the most basic ruff setup with ruff.toml in an initial PR, then follow it up with new PRs adding the rules and applying fixes.

Comment on lines +50 to +60
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: astral-sh/ruff-action@v3
with:
version: "latest"
- name: Ruff lint
run: ruff check --fix
- name: Ruff format
run: ruff format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend adding an action for pre-commit hooks, instead of a ruff-only config.

@ulgens
Copy link
Member

ulgens commented Dec 9, 2025

@mikemanger Would you mind rebasing this branch over #185 ?

This was referenced Dec 10, 2025
@ulgens
Copy link
Member

ulgens commented Dec 10, 2025

Superseded by the collection of following PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants