Skip to content

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Dec 28, 2025

Short description of changes

Adds a link to the privacy policy

CHANGELOG: Add link to privacy policy

Context: Fixes an issue?

Fixes: #3584

Does this change need documentation? What needs to be documented and how?

No. But translation.

Status of this Pull Request

Review

What is missing until this pull request can be merged?

Review

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see added this to the Release 3.12.0 milestone Dec 28, 2025
@ann0see ann0see added this to Tracking Dec 28, 2025
@ann0see ann0see added the iOS iOS runtime issue label Dec 28, 2025
@github-project-automation github-project-automation bot moved this to Triage in Tracking Dec 28, 2025
@ann0see ann0see requested review from pljones and softins December 28, 2025 10:42
@ann0see ann0see moved this from Triage to Waiting on Team in Tracking Dec 28, 2025
@ann0see
Copy link
Member Author

ann0see commented Dec 28, 2025

  • Checked with the updated checkkeys.pl script.

src/util.h Outdated
void OnHelpClientGetStarted() { QDesktopServices::openUrl ( QUrl ( CLIENT_GETTING_STARTED_URL ) ); }
void OnHelpServerGetStarted() { QDesktopServices::openUrl ( QUrl ( SERVER_GETTING_STARTED_URL ) ); }
void OnHelpSoftwareMan() { QDesktopServices::openUrl ( QUrl ( SOFTWARE_MANUAL_URL ) ); }
void OnHelpPrivacyPolicy() { QDesktopServices::openUrl ( QUrl ( PRIVACY_POLICY_URL ) ); }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it going to be okay for the privacy policy to go to an unidentified website (in terms of the not yet having read the privacy policy that would cover the website, too...), rather than displaying the text locally (like OnHelpAbout and OnHelpAboutQt)?

(Also, can we have these in the same order as the menu whilst you're here.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's ok to link outside of the app.

Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works for me.

@ann0see ann0see merged commit 7cfe0f5 into jamulussoftware:main Dec 30, 2025
10 of 11 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Team to Done in Tracking Dec 30, 2025
@ann0see ann0see deleted the iOS/addPrivPol branch December 30, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iOS iOS runtime issue

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add link to privacy policy under About

3 participants