-
Notifications
You must be signed in to change notification settings - Fork 238
Add privacy policy link #3586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add privacy policy link #3586
Conversation
|
src/util.h
Outdated
| void OnHelpClientGetStarted() { QDesktopServices::openUrl ( QUrl ( CLIENT_GETTING_STARTED_URL ) ); } | ||
| void OnHelpServerGetStarted() { QDesktopServices::openUrl ( QUrl ( SERVER_GETTING_STARTED_URL ) ); } | ||
| void OnHelpSoftwareMan() { QDesktopServices::openUrl ( QUrl ( SOFTWARE_MANUAL_URL ) ); } | ||
| void OnHelpPrivacyPolicy() { QDesktopServices::openUrl ( QUrl ( PRIVACY_POLICY_URL ) ); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it going to be okay for the privacy policy to go to an unidentified website (in terms of the not yet having read the privacy policy that would cover the website, too...), rather than displaying the text locally (like OnHelpAbout and OnHelpAboutQt)?
(Also, can we have these in the same order as the menu whilst you're here.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's ok to link outside of the app.
d18bee3 to
26f8a55
Compare
softins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works for me.
Short description of changes
Adds a link to the privacy policy
CHANGELOG: Add link to privacy policy
Context: Fixes an issue?
Fixes: #3584
Does this change need documentation? What needs to be documented and how?
No. But translation.
Status of this Pull Request
Review
What is missing until this pull request can be merged?
Review
Checklist